Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hovering through custom menu button #5555

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Fix hovering through custom menu button #5555

merged 6 commits into from
Jan 22, 2025

Conversation

M4tthewDE
Copy link
Contributor

@M4tthewDE M4tthewDE commented Jan 1, 2025 •
edited
Loading

This change discards widgets which are fully covered by another widget in a higher layer from the hit test algorithm.

@M4tthewDE M4tthewDE marked this pull request as ready for review January 7, 2025 14:34
emilk
emilk approved these changes Jan 11, 2025
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@emilk emilk added bug Something is broken egui labels Jan 11, 2025
emilk
emilk reviewed Jan 11, 2025
View reviewed changes
crates/egui/src/hit_test.rs Outdated Show resolved Hide resolved
emilk
emilk reviewed Jan 11, 2025
View reviewed changes
crates/egui/src/hit_test.rs Outdated Show resolved Hide resolved
crates/egui/src/hit_test.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5555-fixhit-test-clickable-behind-hoverable
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

emilk
emilk reviewed Jan 22, 2025
View reviewed changes
crates/egui/src/hit_test.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 493d5d0 into emilk:master Jan 22, 2025
25 checks passed
@emilk emilk mentioned this pull request Jan 23, 2025
Merged
emilk added a commit to rerun-io/rerun that referenced this pull request Jan 23, 2025
@emilk
Update to latest egui master (#8787)
c105e19 
### Contains these notable fixes
* emilk/egui#5631
* emilk/egui#5555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong handling of menu by list of custom_menu_button
2 participants
@M4tthewDE @emilk